Office Hours bugbusting topics.

These are [[/MarkLinimon|MarkLinimon]]'s ideas for specific topics to work on to help focus efforts during any type of bugbusting session.

:!: the information in this page was adapted from the notes from the [[MarkLinimon/KitchenerNotes|bugbusting working session]] in Kitchener, Ontario, Canada in May 2019.

===== Introduction =====

==== Conventions ====

  * //PR// refers to a [[https://bugs.freebsd.org/bugzilla/|Bugzilla]] Problem Report.
  * //DR// refers to a [[https://reviews.freebsd.org/differential/query/all/|Phabricator]] Differential Revision.

Let's just term them "issues" from here on.

Note that PRs contain a mix of suggested patches along with what is truly a Problem Report; the DRs are almost all patches.

==== General Suggestions ====

  * In the past, bugbusting sessions have worked best when a specific goal was set ahead of time: either:
    * a certain subset of issues, or
    * an preselected list of issues.

  * We can never "fix all the issues".  Trying to do this usually leads to burnout.

  * Although it might seem counter-intuitive, the idea "start with the oldest ones" winds up being very frustrating.  Some of these issues are complex and have been contentious for years.  A better choice is to work backwards.

  * When working older issues, be aware that the submitter may respond negatively even though you are trying to help -- just due to the length of time the issue has sat un-addressed.  Be prepared to be patient.  Nothing is more irrtitating to submitters than closing an issue years after it has been submitted with "oh gosh sorry".  Novice bugbusters may wish to leave those for the hardened old-timers.

===== Working On Existing Issues With Patches =====

==== Resources ====

  * Bugzilla
    * [[https://bugs.freebsd.org/bugzilla/buglist.cgi?keywords=patch%2C%20&keywords_type=allwords&limit=0&list_id=296749&order=bug_id%20DESC&product=Base%20System&query_format=advanced&resolution=---|all base system PRs with patches]] (> 600)
    * [[https://bugs.freebsd.org/bugzilla/buglist.cgi?email1=bugs%40FreeBSD.org&emailassigned_to1=1&emailtype1=substring&keywords=patch%2C%20&keywords_type=allwords&list_id=296748&product=Base%20System&query_format=advanced&resolution=---|all base system PRs with patches]], but assigned to no one (> 250)

  * Phabricator
    * [[https://reviews.freebsd.org/differential/query/CwPZ7FgSQw2N/|base system DRs]] (> 1000)
    * [[https://reviews.freebsd.org/differential/query/7n3XpFrluoen//|all DRs]] (1000s)
    * [[https://reviews.freebsd.org/differential/query/J.KZv4oRAlqm/|needs review]] (> 1000) 
      * I do not know how to get a summary report to get the exact totals.
    * How to search for "DRs with no reviewer?"  Does not seem possible.
      * examples: [[https://reviews.freebsd.org/D19690|D19690]], [[https://reviews.freebsd.org/D19690|D19690]], [[https://reviews.freebsd.org/D17105|D17105]]

==== How To Find Things To Work On ====

  * Bugzilla
    * PRs with patches (see above)
    * PRs assigned to particular mailing lists, e.g. [[https://bugs.freebsd.org/bugzilla/buglist.cgi?email1=net%40FreeBSD.org&emailassigned_to1=1&emailtype1=substring&list_id=296761&product=Base%20System&query_format=advanced&resolution=---|net@]]
      * except in a few cases, not granular enough
      * tip: run general report and sort by assignee
    * one or more [[https://bugs.freebsd.org/bugzilla/describekeywords.cgi|keywords]]
      * our list of keywords is sparse; the taxonomy needs to be defined better.
      * see [[Bugzilla/Keywords]] for slightly longer explanations.

  * Phabricator
    * can create custom queries, but somewhat cumbersome
    * I can't figure out how to query "assigned to no one"
      * Should there be a policy to say "all DRs must a non-null reviewer"?  even if it is a group?

==== Specific ideas for bugbusting office hours ====

  * [[https://bugs.freebsd.org/bugzilla/buglist.cgi?bug_status=New&component=kern&email1=bugs%40FreeBSD.org&emailassigned_to1=1&emailtype1=substring&keywords=patch&keywords_type=allwords&list_id=296897&product=Base%20System&query_format=advanced&resolution=---|bugzilla src PRs with patches, assigned to no one, in state "new"]] (~60)

===== Working On Other Issues =====

==== Resources ====

  * Bugzilla
    * your [[https://bugs.freebsd.org/bugzilla/page.cgi?id=dashboard.html|Bugzilla dashboard]]
    * all [[https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=saved-searches|Saved Searches]]
    * all [[https://bugs.freebsd.org/bugzilla/buglist.cgi?keywords=regression&keywords_type=allwords&list_id=362157&order=assigned_to%2Cproduct%2Ccomponent%2Cbug_id&query_format=advanced&resolution=---|open PRs tagged with regression]]
    * [[https://adventurist.me/posts/00301|Command Line Bug Hunting in FreeBSD]] (external blog post by [[/TomJones|TomJones]])
      * as of 0.13_1, [[https://www.freshports.org/devel/pybugz/|pybugz]] no longer needs **--connection %%FreeBSD%%** added. 

----

{{tag>HowTo}}