Differences
This shows you the differences between two versions of the page.
| Both sides previous revision Previous revision Next revision | Previous revision | ||
| githubpullrequests [2017/03/01 17:23] – WarnerLosh | githubpullrequests [2017/03/01 21:00] (current) – Add notes (as used by svn2git) to remote example EdMaste | ||
|---|---|---|---|
| Line 1: | Line 1: | ||
| - | ====== Github Pull Request Policy ====== | ||
| - | |||
| - | %%-%%--- :!: **Edit conflict - other version:** ---- | ||
| - | Here's a rough outline of the %%FreeBSD%%' | ||
| - | |||
| - | * Github pull requests should be made for mature code that's ready to commit. The pull request should include a description of the problem being solved as well as a commit message that meets the %%FreeBSD%% project' | ||
| - | * Github pull requests should not be used for discussion. If you'd like to use github as a tool to discuss changes, you can do that with your own private account. Phabricator remains the project' | ||
| - | * Incomplete code that's submitted may be converted into a bugzilla request at the discretion of the project. | ||
| - | * When nobody can be found to review the change, it will be converted to a bugzilla request. | ||
| - | * When the domain experts would rather work with another tool, a pull request will be converted to that other tool. | ||
| - | * Pull requests older than 18 months will be converted to bugzilla items to not lose them. | ||
| - | * When making pull requests that are non-trivial (trivial changes include adding new devices to a driver, fixing spelling, correcting minor bugs in non-critical systems), it's strongly recommended that the domain experts be sought out to review and take ownership of the request. | ||
| - | * Pull requests that are for software included in %%FreeBSD%% that have upstream sources should be submitted there first. Incorrectly submitted changes will receive a redirect and closed. | ||
| - | * If there' | ||
| - | * Issues unresolved on github after about a month will result in the pull request being transitioned to bugzilla or closed at the discretion of the project. | ||
| - | * Best Effort Only. The project will make efforts to look at the pull requests from time to time. We make no timeliness guarantees at this time. Github pull requests remain an experimental feature of the project and may not get the time and attention of more mature efforts. If the submitter doesn' | ||
| - | |||
| - | %%-%%--- :!: **Edit conflict - your version:** ---- | ||
| Here's a rough outline of the %%FreeBSD%%' | Here's a rough outline of the %%FreeBSD%%' | ||
| * Github pull requests should be made for mature code that's ready to commit. The pull request should include a description of the problem being solved as well as a commit message that meets the %%FreeBSD%% project' | * Github pull requests should be made for mature code that's ready to commit. The pull request should include a description of the problem being solved as well as a commit message that meets the %%FreeBSD%% project' | ||
| - | * Code that still needs discussion or consensus building is not ready to submit | + | * Code that still needs discussion or consensus building is not ready to submit as a pull request. Discussions and consensus building should happen in the appropriate project mailing list. |
| - | * Github pull requests to the project should not be used for discussion. | + | * Github pull requests to the project should not be used for discussion. |
| - | * When making | + | * Before |
| * Pull requests that are for third party software should be submitted upstream first. | * Pull requests that are for third party software should be submitted upstream first. | ||
| - | * If there' | + | * If there' |
| - | * Any pull request that isn't ready to go into the tree may be closed. Best effort attempts to redirect to bugzilla | + | * Any pull request that isn't ready to go into the tree may be closed. Best effort attempts to redirect to Bugzilla |
| * Stale requests may be closed with a request for rebase and a new pull request. | * Stale requests may be closed with a request for rebase and a new pull request. | ||
| * This is a best effort only service. The project will try make efforts to resolve pull requests from time to time. We make no timeliness guarantees at this time. Github pull requests remain an experimental feature of the project and may not get the time and attention of more mature efforts. If the submitter doesn' | * This is a best effort only service. The project will try make efforts to resolve pull requests from time to time. We make no timeliness guarantees at this time. Github pull requests remain an experimental feature of the project and may not get the time and attention of more mature efforts. If the submitter doesn' | ||
| - | Subject to change in the future as resources change and new tooling is created. | + | Subject to change in the future as resources change and new tooling is created. |
| + | |||
| + | ===== Fetching pull requests into local repo ===== | ||
| + | To include pull requests when fetching add the following entry to the appropriate remote config in .git/ | ||
| + | |||
| + | For example, the full remote entry may look like: | ||
| + | |||
| + | < | ||
| + | [remote " | ||
| + | url = https:// | ||
| + | fetch = +refs/ | ||
| + | fetch = +refs/ | ||
| + | fetch = +refs/ | ||
| + | </ | ||
| - | %%-%%--- :!: **End of edit conflict** ---- | + | After fetching from this remote, individual pull requests can be examined with commands like '' |