This is an old revision of the document!


Github Pull Request Policy

  • Github pull requests should be made for mature code that's ready to commit. The pull request should include a description of the problem being solved as well as a commit message that meets the FreeBSD project's standards.
  • Github pull requests may also be used to discuss potential changes, but only if the submitter and reviews have agreed to this in advance. Blind submissions of incomplete code should not be met.
  • Incomplete code that's submitted may be converted into a bugzilla request that the discretion of the project. When nobody can be found to review the change, it will be converted to a bugzilla request. When the domain experts would rather work with another tool, a pull request will be converted to that other tool.
  • Pull requests older than 18 months will be converted to bugzilla items to not lose them.
  • When making pull requests that are non-trivial (trivial changes include adding new devices to a driver, fixing spelling, correcting minor bugs in non-critical systems), it's strongly recommended that the domain experts be sought out to review and take ownership of the request.
  • Best Effort. The project will make efforts to look at the pull requests from time to time. We make no timeliness guarantees at this time. Github pull requests remain an experimental feature of the project and may not get the time and attention of more mature efforts.
  • githubpullrequests.1488328351.txt.gz
  • Last modified: 2017/03/01 00:32
  • by WarnerLosh