Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
java:portlint [2005/03/01 17:10] – Fix typos and case HerveQuirozjava:portlint [2017/09/18 06:51] (current) – renamed from JavaPortlint KubilayKocak
Line 2: Line 2:
  
 I am no Perl hacker nor I have time to learn Perl for now. Still there are many Java related sanity checks that could be performed by portlint. I will list them here just in case some volunteer shows up... I am no Perl hacker nor I have time to learn Perl for now. Still there are many Java related sanity checks that could be performed by portlint. I will list them here just in case some volunteer shows up...
- 
-==== bsd.java.mk 2.0 syntax ==== 
- 
-**WHEN:** defined(_USE_BSD_JAVA_MK_1_0) 
- 
-**LEVEL:** Warning (but will soon be Critical) 
- 
-**MESSAGE:** The port uses bsd.java.mk 1.0 syntax. You should consider updating it to 2.0 syntax. Please refer to the Porter's handbook for further information. 
  
 ==== Use of Java features without USE_JAVA ==== ==== Use of Java features without USE_JAVA ====
Line 18: Line 10:
  
 **MESSAGE:** The port uses Java features but USE_JAVA is not defined. **MESSAGE:** The port uses Java features but USE_JAVA is not defined.
- 
-==== Use of Ant and GNU Make ==== 
- 
-**WHEN:** defined(USE_ANT) && defined(USE_GMAKE) 
- 
-**LEVEL:** Warning 
- 
-**MESSAGE:** A port shall not define both USE_ANT and USE_GMAKE. 
- 
-==== Use of Ant and do-build ==== 
- 
-**WHEN:** defined(USE_ANT) && target(do-build) 
- 
-**LEVEL:** Critical 
- 
-**MESSAGE:** USE_ANT is intended only for ports that build with Ant. You should not override 'do-build' when also defining USE_ANT. 
  
 ==== Use of Java features without the 'java' category ==== ==== Use of Java features without the 'java' category ====
Line 42: Line 18:
  
 **MESSAGE:** The port uses Java but is not part of the 'java' category. **MESSAGE:** The port uses Java but is not part of the 'java' category.
- 
-==== Only 'java' category ==== 
- 
-**WHEN:** ''%% "${CATEGORIES:Mjava}" == "${CATEGORIES}" %%'' 
- 
-**LEVEL:** Critical 
- 
-**MESSAGE:** The java category shall not be the only one for a port. 
- 
-==== 'java' main catefory ==== 
- 
-**WHEN:** echo "${CATEGORIES}" | grep -q '^java' 
- 
-**LEVEL:** Warning 
- 
-**MESSAGE:** Save for ports directly related to the Java language, porters are also encouraged not to use java as the main category of a port. 
- 
-//NOTE: This check is only to be performed for new ports// 
  
 ==== NO_BUILD and JAVA_BUILD ==== ==== NO_BUILD and JAVA_BUILD ====
Line 102: Line 60:
  
 **MESSAGE:** Since javavmwrapper 2.0, the 'javavm' command to invoke a JVM is deprecated. Use 'java' instead. **MESSAGE:** Since javavmwrapper 2.0, the 'javavm' command to invoke a JVM is deprecated. Use 'java' instead.
 +
 +----
 +
 +//Now that 1.0 syntax support, was removed from bsd.java.mk, here is a set of new tests to be performed by portlint://
 +
 +==== Syntax for USE_JAVA ====
 +
 +**WHEN:** USE_JAVA is not of the form ''%%1\.[0-9]+?( 1\.[0-9]+?)*%%'' (e.g. "1.2", "1.1 1.4+", "1.1 1.2 1.3 1.4")
 +
 +**LEVEL:** Critical
 +
 +**MESSAGE:** USE_JAVA should be of the form 1.[0-9]+?( 1\.[0-9]+?)*
 +
 +==== Use of %%JAVAJARDIR%% in pkg-plist ====
 +
 +**WHEN:** pkg-plist contains ''%%share/java/classes%%''
 +
 +**LEVEL:** Critical
 +
 +**MESSAGE:** Consider using <nowiki>%%</nowiki>JAVAJARDIR<nowiki>%%</nowiki> rather than "share/java/classes" in pkg-plist
 +
 +==== Use of %%JAVAJARDIR%% in rc scripts ====
 +
 +**WHEN:** some file as ${FILESDIR}/*.sh.in contains ''%%share/java/classes%%''
 +
 +**LEVEL:** Warning
 +
 +**MESSAGE:** Consider using <nowiki>%%</nowiki>JAVAJARDIR<nowiki>%%</nowiki> rather than "share/java/classes" in %%<%%filename>
  
  • java/portlint.1109697026.txt.gz
  • Last modified: 2005/03/01 17:10
  • by HerveQuiroz