Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
kyleevans:bsdgrep [2017/05/02 20:17] – D10572 complete EdMastekyleevans:bsdgrep [2021/04/25 05:06] (current) – Chase link rename KubilayKocak
Line 14: Line 14:
 == Chunking == == Chunking ==
  
-A potential plan for doing chunk processing instead of full line processing may be found at [[BSDgrep/Chunking|BSDgrep/Chunking]].+A potential plan for doing chunk processing instead of full line processing may be found at [[KyleEvans/BSDgrep/Chunking]].
  
 === Open Reviews / PRs === === Open Reviews / PRs ===
-Reviews with a positive disposition: 
  
-Reviews needing reviewed: +Pending reviews: 
-  * [[https://reviews.freebsd.org/D10098|D10098]] (Fix escape map building for multibyte strings) +  * [[https://reviews.freebsd.org/D10833|D10833]] (Pet clang-scan)
-  * [[https://reviews.freebsd.org/D10420|D10420]] (#define REG_NOSPEC 0 if not defined for no side effects) +
-  * [[https://reviews.freebsd.org/D10433|D10433]] (Fix -w flag matching with an empty pattern)+
  
 Postponed reviews: Postponed reviews:
Line 34: Line 31:
   * [[https://reviews.freebsd.org/D10456|D10456]] (Correct nls/ catalogs after -z/--null-data addition)   * [[https://reviews.freebsd.org/D10456|D10456]] (Correct nls/ catalogs after -z/--null-data addition)
   * [[https://reviews.freebsd.org/D10572|D10572]] (Revise test case and error output in response to impending [[https://reviews.freebsd.org/D10315|D10315]])   * [[https://reviews.freebsd.org/D10572|D10572]] (Revise test case and error output in response to impending [[https://reviews.freebsd.org/D10315|D10315]])
 +  * [[https://reviews.freebsd.org/D10433|D10433]] (Fix -w flag matching with an empty pattern)
 +  * [[https://reviews.freebsd.org/D10098|D10098]] (Fix escape map building for multibyte strings)
 +  * [[https://reviews.freebsd.org/D10420|D10420]] (#define REG_NOSPEC 0 if not defined for no side effects)
 +  * [[https://reviews.freebsd.org/D10607|D10607]] (Unbreak -l flag output)
 +  * [[https://reviews.freebsd.org/D10620|D10620]] (Add more exhaustive tests for different binary flags, -a/-I/-U)
 +  * [[https://reviews.freebsd.org/D10675|D10675]] (Don't allow negative values for -A/-B/-C)
 +  * [[https://reviews.freebsd.org/D10820|D10820]] (Fix --mmap behavior [again])
 +  * [[https://reviews.freebsd.org/D10577|D10577]] (Print matches beyond MAX_LINE_MATCHES)
 +  * [[https://reviews.freebsd.org/D10580|D10580]] (Correctly print per-line metadata w/ -b/-H/-n and -o/--color)
 +  * [[https://reviews.freebsd.org/D10824|D10824]] (Correct assumptions that don't hold up for chunking)
 +  * [[https://reviews.freebsd.org/D10827|D10827]] (Add --mmap tests)
  
 PRs to fix issues from exp-run ([[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218385|PR 218385]]): PRs to fix issues from exp-run ([[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218385|PR 218385]]):
-  * [[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218638|PR 218638]] (net-im/folks, poked kwm@) 
   * [[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218639|PR 218639]] (astro/geographiclib, waiting on miwi@ assigned to regular update then will rebase 218639)   * [[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218639|PR 218639]] (astro/geographiclib, waiting on miwi@ assigned to regular update then will rebase 218639)
-  * [[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218811|PR 218811]] (graphics/libglapi, to be fixed after D10433, fix pending locally) 
  
 Worth noting is that some chunk of these PRs is (was) to stop relying on GNU extensions in base, changing them to use [[http://www.freshports.org/textproc/gnugrep/|textproc/gnugrep]] instead of base grep. Once BSDgrep becomes more capable, these and others currently relying on textproc/gnugrep will be re-evaluated for losing this dependency and instead using grep in base. There is a working plan for GNU extension re-implementation. Worth noting is that some chunk of these PRs is (was) to stop relying on GNU extensions in base, changing them to use [[http://www.freshports.org/textproc/gnugrep/|textproc/gnugrep]] instead of base grep. Once BSDgrep becomes more capable, these and others currently relying on textproc/gnugrep will be re-evaluated for losing this dependency and instead using grep in base. There is a working plan for GNU extension re-implementation.
Line 54: Line 60:
  
 To revert this, re-do the steps above, omitting the ''%%WITH_BSD_GREP=yes WITHOUT_GNU_COMPAT=yes%%'' part. To revert this, re-do the steps above, omitting the ''%%WITH_BSD_GREP=yes WITHOUT_GNU_COMPAT=yes%%'' part.
 +
 +----
 +
 +{{tag>Stale Todo}}
  
  • kyleevans/bsdgrep.1493756257.txt.gz
  • Last modified: 2017/05/02 20:17
  • by EdMaste