Upgrade boost from 1.55 to 1.60

This wiki page is based on the following bug-request:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199601#c27

truckmans' logs for the following list: https://people.freebsd.org/~truckman/boost-1.60_fallout/r405759/FreeBSD-10.1-amd64/

error: no matching function for call to 'operator!='
note: in expansion of macro 'LUABIND_OPERATOR_ADL_WKND'
   LUABIND_OPERATOR_ADL_WKND(!=)
   ^

This is luabind problem (probably in bundled version of luabind).

Examples: devel/luabind, games/allacrost, games/valyriatear

Solution: you need to patch luabind/object.hpp like this

Parse error at "BOOST_JOIN"

Qt4's moc fails to parse macros in namespace declarations, like this in boost/type_traits/detail/has_binary_operator.hpp:

namespace BOOST_JOIN(BOOST_TT_TRAIT_NAME,_impl) {

There is an upstream bug about this and it is fixed in Qt 5, but there are no plans to backport the fix to Qt 4.

Examples: audio/clementine-player, cad/openscad, graphics/evolvotron

Solution: It is possible to solve the problem in two different ways:

1. Make moc automatically define the include guards for the headers that ultimately include the other headers that use namespace BOOST_JOIN, so that moc does not include them and does not fail to process a port's includes. It involves some trial and error to find out which headers must be skipped. It helps to replace the moc-qt4 invocation with c++ -E to see which headers are being included where. Once you have figured out which headers must be skipped, edit devel/qt4-moc/files/patch-src__tools__moc__main.cpp and add their include guards to the list.

2. Instead of changing moc, wrap the Boost includes in a port within an #ifndef Q_MOC_RUN block so that moc just skips them when processing a port's source code.

#ifndef Q_MOC_RUN
#include <boost/...>
#endif

It can be quicker than the other solution, but requires patching a lot of files in many different ports.

error: reference to 'ifstream' is ambiguous

Namespace conflict between std::ifstream and boost::filesystem::ifstream (or ofstream).

Examples: games/pokerth, games/traingame

Solution: resolve the conflict by using fully qualified name. Since boost/filesystem/fstream.hpp is included only in newer boost, it is likely that std streams are actually meant, so you need to replace [io]fstream mentions by std::[io]fstream correspondingly:

@${FIND} ${WRKSRC} -name '*.cpp' -print0 | ${XARGS} -0 \
	${REINPLACE_CMD} -e 's|[io]fstream|std::&|'

undefined reference to `boost::system::generic_category()'

Examples: devel/codeblocks, www/anyterm

Solution: link with needed boost libraries

LIBS+=          -L${LOCALBASE}/lib -lboost_system

It was a hack for broken old compilers, no op on actual clang and gcc that we use.

Examples: graphics/aqsis

Solution: just remove pfto.hpp includes and BOOST_MAKE_PFTO_WRAPPER.

error: use of undeclared identifier 'BOOST_CHECKPOINT'

This is deprecated API which was removed in 1.60 or earlier. See this.

Examples: devel/avro-cpp

Solution: Replace BOOST_CHECKPOINT with BOOST_TEST_CHECKPOINT, BOOST_MESSAGE with BOOST_TEST_MESSAGE, BOOST_BITWISE_EQUAL with BOOST_CHECK_BITWISE_EQUAL.

/usr/local/include/boost/graph/adjacency_matrix.hpp:446:5: error: type name requires a specifier or qualifier
    BOOST_STATIC_ASSERT(type_traits::ice_not<(is_same<Directed, bidirectionalS>::value)>::value);
    ^

Examples: databases/sfcgal (actually math/cgal)

Solution: Bug in boost. Need to explicitly include <boost/type_traits/ice.hpp> for boost 1.60

+// Workaround for boost bug #11880
+#include <boost/version.hpp>
+#if BOOST_VERSION == 106000
+	#include <boost/type_traits/ice.hpp>
+#endif